feat: merklelization of lists #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbda_ethereum_consensus into merklelization-of-lists
…mbda_ethereum_consensus into merklelization-of-lists
…mbda_ethereum_consensus into merklelization-of-lists
MegaRedHand
reviewed
Jan 10, 2024
| interior_count = node_count - leaf_count | ||
| leaf_start = interior_count * @bytes_per_chunk | ||
| padded_chunks = chunks |> convert_to_next_pow_of_two(leaf_count) | ||
| buffer = <<0::size(leaf_start * @bits_per_byte), padded_chunks::bitstring>> |
There was a problem hiding this comment.
We can leave this for the next PR, but using a binary as a buffer in Elixir kills performance, in the same way using a tuple does. Each time you modify a binary, the VM has to copy it whole, so this is bound to be really slow for big enough inputs. (unless you do it the right way: https://stackoverflow.com/questions/46095870/whats-the-best-way-to-build-long-strings-in-elixir)
As a simple solution, using a list or array and then joining its values once at the end should work.
…mbda_ethereum_consensus into merklelization-of-lists
|
The failing test is not from this PR. @MegaRedHand can you please take a look? |
|
Please pull the newest commits from main. It should have been fixed by #607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #482